Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOT Approved]Disable useEnvironmentVariableValues by default because of regression issue #4728 #4732

Closed
wants to merge 1 commit into from
Closed

[NOT Approved]Disable useEnvironmentVariableValues by default because of regression issue #4728 #4732

wants to merge 1 commit into from

Conversation

joviegas
Copy link
Contributor

@joviegas joviegas commented Dec 1, 2023 •
edited
Loading

Motivation and Context

Disable useEnvironmentVariableValues by default because of regression issue #4728

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner December 1, 2023 18:07
@joviegas
Copy link
Contributor Author

joviegas commented Dec 1, 2023

Had an internal review for this and we came to conclusion we should not change the SDK default behavior to give preference to Environment variable since this is the right way and might break other customers.
Thus we will not merge this PR , will check for suggestions from the requester if there is some other feasible solution we can provide from SDK side to handle this case.

@joviegas joviegas closed this Dec 1, 2023
@joviegas joviegas changed the title Disable useEnvironmentVariableValues by default because of regression issue #4728 [NOT Approved]Disable useEnvironmentVariableValues by default because of regression issue #4728 Dec 1, 2023
@joviegas joviegas deleted the joviegas/env_regression branch May 15, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joviegas